1   package test.net.sourceforge.pmd.rules.finalize;
2   
3   import net.sourceforge.pmd.PMD;
4   import net.sourceforge.pmd.Rule;
5   import net.sourceforge.pmd.RuleSetNotFoundException;
6   import test.net.sourceforge.pmd.testframework.SimpleAggregatorTst;
7   import test.net.sourceforge.pmd.testframework.TestDescriptor;
8   
9   public class FinalizeDoesNotCallSuperFinalizeRuleTest extends SimpleAggregatorTst {
10  
11      private Rule rule;
12  
13      public void setUp() throws RuleSetNotFoundException {
14          rule = findRule("rulesets/finalizers.xml", "FinalizeDoesNotCallSuperFinalize");
15      }
16  
17      public void testAll() {
18         runTests(new TestDescriptor[] {
19             new TestDescriptor(TEST1, "bad", 1, rule),
20             new TestDescriptor(TEST2, "ok", 0, rule),
21         });
22      }
23  
24      private static final String TEST1 =
25      "public class Foo {" + PMD.EOL +
26      " public void finalize() {" + PMD.EOL +
27      "  super.finalize();" + PMD.EOL +
28      "  int x = 2;" + PMD.EOL +
29      " }" + PMD.EOL +
30      "}";
31  
32      private static final String TEST2 =
33      "public class Foo {" + PMD.EOL +
34      " public void finalize() {" + PMD.EOL +
35      "  int x = 2;" + PMD.EOL +
36      "  super.finalize();" + PMD.EOL +
37      " }" + PMD.EOL +
38      "}";
39  
40  /*
41  TODO
42  This should handle a call to super.finalize() within a finally block, e.g.
43  
44  protected void finalize()
45  {
46     try { //  do something
47      }
48     finally
49     {
50        super.finalize(); // this is OK and should not be flagged
51     }
52  }
53  */
54  }